Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/triage: fix excessive-permissions zizmor error #195310

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

samford
Copy link
Member

@samford samford commented Dec 15, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

This addresses the excessive-permissions error from zizmor by moving the workflow permissions to the jobs where they're needed.

@samford samford force-pushed the zizmor-triage-excessive-permissions branch from fbb3124 to 4c85cee Compare December 15, 2024 19:01
@samford samford changed the title workflows/triage: fix excessive-permissions zizmor findings workflows/triage: fix excessive-permissions zizmor error Dec 15, 2024
This addresses the `excessive-permissions` error from `zizmor` by
moving the workflow permissions to the jobs where they're needed.
@samford samford force-pushed the zizmor-triage-excessive-permissions branch from 4c85cee to 974fbb3 Compare December 19, 2024 21:59
@samford samford merged commit 43a7b9d into master Dec 19, 2024
15 checks passed
@samford samford deleted the zizmor-triage-excessive-permissions branch December 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants