Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve, define Python library exception list #16662

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Feb 15, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@iMichka
Copy link
Member Author

iMichka commented Feb 15, 2024

@woodruffw I have some doubts about the ### Installing libraries, ### Dependencies for libraries, ### Setuptools vs. Distutils vs. pip parts: looks like a lot of this is now outdated, especially with PEP 668.
We can either rework it in this pull request, or do it in a second batch.

iMichka added a commit to iMichka/brew that referenced this pull request Feb 15, 2024
See Homebrew#16662

We would like to enforce vendoring for Python libraries,
or the usage of a virtualenv in the formula's libexec directory,
using a virtualenv.
@woodruffw
Copy link
Member

We can either rework it in this pull request, or do it in a second batch.

I'm +1 on doing it in a second batch, to keep things small here.

iMichka added a commit to iMichka/brew that referenced this pull request Feb 15, 2024
See Homebrew#16662

We would like to enforce vendoring for Python libraries,
or the usage of a virtualenv in the formula's libexec directory,
using a virtualenv.
iMichka added a commit to iMichka/brew that referenced this pull request Feb 19, 2024
See Homebrew#16662

We would like to enforce vendoring for Python libraries,
or the usage of a virtualenv in the formula's libexec directory,
using a virtualenv.
iMichka added a commit to iMichka/brew that referenced this pull request Feb 19, 2024
See Homebrew#16662

We would like to enforce vendoring for Python libraries,
or the usage of a virtualenv in the formula's libexec directory,
using a virtualenv.
Copy link

github-actions bot commented Apr 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

docs/Python-for-Formula-Authors.md Outdated Show resolved Hide resolved
@cho-m
Copy link
Member

cho-m commented Apr 5, 2024

@iMichka, is there anything you wanted to add/update or are we good to merge?

I think the open/unresolved discussions can be handled in next round given that it looks like we were planning another rework?

We can either rework it in this pull request, or do it in a second batch.

I'm +1 on doing it in a second batch, to keep things small here.


We can expand any exceptions as necessary. I've created a table of various formulae in Homebrew/homebrew-core#167905 and will be triaging them.

@iMichka iMichka force-pushed the python-acceptable branch from 99c6fb2 to ecc181c Compare April 9, 2024 19:15
@iMichka
Copy link
Member Author

iMichka commented Apr 9, 2024

@cho-m I resolved the different comments that were made. We can merge as-is and iterate from here, you are right.

@MikeMcQuaid MikeMcQuaid enabled auto-merge April 10, 2024 07:39
@MikeMcQuaid
Copy link
Member

Thanks again @iMichka!

@MikeMcQuaid MikeMcQuaid merged commit ef1c54e into Homebrew:master Apr 10, 2024
25 checks passed
@iMichka iMichka deleted the python-acceptable branch April 10, 2024 15:15
@github-actions github-actions bot added the outdated PR was locked due to age label May 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants