Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get sample app compiling with RubyMotion 6 #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

digitalmoksha
Copy link
Contributor

The sample app was no longer building properly, so I

  • Regenerated the sample app using RubyMotion 6.1
  • Removed 3rd party Fabric kits, which are now deprecated
  • Updated readme with information on the deprecation

Removed inclusion of older Fabric kits that will no
longer be supported in Fabric and have difficulty
compiling.
Copy link

@andrewhavens andrewhavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me

@andrewhavens
Copy link

Long term goal: we should work on updating the motion-firebase gem to work with Crashlytics. I forked a copy that we can work on here: https://github.com/rubymotion-community/motion-firebase

@digitalmoksha
Copy link
Contributor Author

I agree, motion-firebase probably needs an update. I didn't realize it existed already 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants