Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codesign embedded_frameworks for OS X too (was: [OS X] Add codesign_frameworks to configuration. Use it to specify which frameworks to codesign) #172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hboon
Copy link
Contributor

@hboon hboon commented Sep 20, 2014

Use it like this:

app.codesign_frameworks << 'Sparkle.framework'

Relevant:

@Watson1978
Copy link
Member

I think app.embedded_frameworks should do code-signing on also OSX platform like iOS platform instead of introducing codesign_frameworks.

@hboon hboon force-pushed the osx-codesign-frameworks branch from dbc2b08 to 185c8fd Compare September 22, 2014 08:11
@hboon hboon changed the title [OS X] Add codesign_frameworks to configuration. Use it to specify which frameworks to codesign Codesign embedded_frameworks for OS X too (was: [OS X] Add codesign_frameworks to configuration. Use it to specify which frameworks to codesign) Sep 22, 2014
@hboon
Copy link
Contributor Author

hboon commented Sep 22, 2014

Great idea. I forgot iOS now supports embedded_frameworks.

Here's a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants