Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlfluff 3.0.6 with config update #3663

Closed
wants to merge 4 commits into from
Closed

Sqlfluff 3.0.6 with config update #3663

wants to merge 4 commits into from

Conversation

max-ostapenko
Copy link
Contributor

#3656 breaks sql linting due to outdated config.
So branch dependabot/pip/src/sqlfluff-3.0.6 can be removed after merging this one.

  • version bump to 3.0.6
  • config errors and warnings fixed
  • SQL fixed ???

Maybe there is no point in checking past years?
See some SQL formatting example as a result of: $ sqlfluff fix ../sql/2022. All makes sense to me.
There are a few issues in 2022 that require a manual fix:

(.venv) maxostapenko@Maxs-MBP src % sqlfluff lint ../sql/2022 
== [../sql/2022/caching/header_trends.sql] FAIL                                                                                                   
L:  53 | P:  48 | AL08 | Reuse of column alias 'total_using_both' from line 42.                                                                   
                       | [aliasing.unique.column]
L:  54 | P:  56 | AL08 | Reuse of column alias 'total_using_neither' from line
                       | 43. [aliasing.unique.column]
L:  71 | P:  59 | AL08 | Reuse of column alias 'pct_using_both' from line 60.
                       | [aliasing.unique.column]
L:  72 | P:  67 | AL08 | Reuse of column alias 'pct_using_neither' from line 61.
                       | [aliasing.unique.column]
== [../sql/2022/css/meta_unknown_properties.sql] FAIL                                                                                             
L:  51 | P:  45 | AL08 | Reuse of column alias 'total' from line 48.                                                                              
                       | [aliasing.unique.column]
== [../sql/2022/media/video_source_formats.sql] FAIL                                                                                              
L:  11 | P:   5 | AL08 | Reuse of column alias 'video_source_format_type' from                                                                    
                       | line 9. [aliasing.unique.column]
== [../sql/2022/performance/lcp_element_data.sql] FAIL                                                                                            
L: 112 | P:  15 | AL08 | Reuse of column alias 'total' from line 100.                                                                             
                       | [aliasing.unique.column]
== [../sql/2022/security/feature_adoption_by_country.sql] FAIL                                                                                    
L:  28 | P: 116 | AL08 | Reuse of column alias 'pct_csp' from line 27.                                                                            
                       | [aliasing.unique.column]
== [../sql/2022/seo/lighthouse_unused_css_js_by_rank.sql] FAIL                                                                                    
L:  31 | P:   5 | CV09 | Use of blocked regex                                                                                                     
                       | '`httparchive.lighthouse.2022_07_01_*`'.
                       | [convention.blocked_words]
== [../sql/2022/seo/pages-canonical-stats.sql] FAIL                                                                                               
L: 167 | P:   5 | CV09 | Use of blocked regex '`httparchive.pages.2022_07_01_*`'.                                                                 
                       | [convention.blocked_words]
== [../sql/2022/seo/robots-text-size.sql] FAIL                                                                                                    
L:  40 | P:   5 | CV09 | Use of blocked regex '`httparchive.pages.2022_07_01_*`'.                                                                 
                       | [convention.blocked_words]
All Finished 📜 🎉!      

dependabot bot and others added 4 commits May 7, 2024 17:44
Bumps [sqlfluff](https://github.com/sqlfluff/sqlfluff) from 1.4.5 to 3.0.6.
- [Release notes](https://github.com/sqlfluff/sqlfluff/releases)
- [Changelog](https://github.com/sqlfluff/sqlfluff/blob/main/CHANGELOG.md)
- [Commits](sqlfluff/sqlfluff@1.4.5...3.0.6)

---
updated-dependencies:
- dependency-name: sqlfluff
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@max-ostapenko max-ostapenko marked this pull request as ready for review May 19, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant