Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(interactive): also use LCP as bounds in observed metric #16173

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+25 −9
Open

core(interactive): also use LCP as bounds in observed metric #16173

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a5abc4
misc: fix doc comment for InteractiveMetric audit
connorjclark Sep 3, 2024
d4fea90
fix findOverlappingQuietPeriods
connorjclark Sep 3, 2024
2d7d726
Merge branch 'main' into fix-interactive-doccomment
connorjclark Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/audits/metrics/interactive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);

/**
* @fileoverview This audit identifies the time the page is "consistently interactive".
* Looks for the first period of at least 5 seconds after FCP where both CPU and network were quiet,
* Looks for the first period of at least 5 seconds after LCP where both CPU and network were quiet,
* and returns the timestamp of the beginning of the CPU quiet period.
* @see https://docs.google.com/document/d/1GGiI9-7KeY3TPqS3YT271upUVimo-XiL5mwWorDUD4c/edit#
*/
Expand Down
Loading