[feat][report-converter][fix][server] Add support for bug path arrows into sarif parser. #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarif files contain all the information required to construct the arrows. This commit extracts that information and uses it in the report.
…dded to the database The current mass_store_run makes the assumption that the report object is well formed. However with sarif support there are multiple valid formats, this commit protects against invalid formats.
jstevens176
force-pushed
the
sarif-bug-paths
branch
from
162c7ad to
45eb40b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current status quo supports SARIF but doesn't allow you to use the "show arrows" feature within the report detail view. This PR extracts the relevant data from the SARIF files and provides the database the means to draw the arrows, making "show arrows" usable.
This exposed an issue with the current server ingest process, in that it assumes a certain format for the BugPath positions and event objects. This PR also adds a number of checks to correctly extract the data as required.