[fix] Don't crash when diagtool is missing #4399
Conversation
For clang-tidy the set of warnings can be queried by a tool named `diagtool`. In some environments `clang` is a symlink to `ccache`. Since CodeChecker tries to find `diagtool` right next to clang, this logic doesn't work, since `diagtool` is usually not next to `ccache`. In this patch CodeChecker searches `diagtool` in the next element of `PATH` environment variable in case `clang` is a symlink to `ccache`, since `ccache` would do the same, too. Fixes Ericsson#4371
bruntib
added
CLI 💻
|
I am getting a similar error: CodeChecker analyze ./compile_commands.json -o reports |
| @@ -13,8 +13,10 @@ | |||
| import ast | |||
| import json | |||
| import os | |||
| from pathlib import Path | |||
| @@ -128,12 +130,28 @@ def get_diagtool_bin(): | |||
| if not clang_bin: | |||
| return None | |||
|
|
|||
| path_env = os.environ['PATH'].split(os.pathsep) | |||
There was a problem hiding this comment.
So then we are always expecting PATH to be present?
| path_env = os.environ['PATH'].split(os.pathsep) | ||
| clang_path = Path(clang_bin) | ||
|
|
||
| if clang_path.resolve().name == 'ccache': |
There was a problem hiding this comment.
Is the problem only defined to ccache?
Shouldnt you check if clang_bin is a symlink?
For clang-tidy the set of warnings can be queried by a tool named
diagtool. In some environmentsclangis a symlink toccache. Since CodeChecker tries to finddiagtoolright next to clang, this logic doesn't work, sincediagtoolis usually not next toccache.In this patch CodeChecker searches
diagtoolin the next element ofPATHenvironment variable in caseclangis a symlink toccache, sinceccachewould do the same, too.Fixes #4371