Add clang-tidy yaml report converter #4335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraz31
force-pushed
the
clang_tidy_yaml
branch
6 times, most recently
from
bfc6fc9 to
4ce83eb
Compare
noraz31
force-pushed
the
clang_tidy_yaml
branch
from
b32ed15 to
e5e990a
Compare
noraz31
force-pushed
the
clang_tidy_yaml
branch
2 times, most recently
from
8ed6250 to
c4e8a95
Compare
Currently clang-tidy reports are parsed and converted to plist files from the clang-tidy standard outputs. This change adds a new report converter that uses clang-tidy's yaml outputs as inputs for parsing and creating plist files.
noraz31
force-pushed
the
clang_tidy_yaml
branch
from
2c5a4ff to
9c6e430
Compare
cservakt
requested changes
Nov 6, 2024
|
|
||
| reports = [] | ||
| if data: | ||
| for diagnostic in data['Diagnostics']: |
There was a problem hiding this comment.
Suggested change
| for diagnostic in data['Diagnostics']: | |
| for diagnostic in data.get("Diagnostics", []): |
Comment on lines
+57
to
+59
| checker_name = diagnostic['DiagnosticName'] | ||
| diagnostic_message = diagnostic['DiagnosticMessage'] | ||
| file_path = os.path.abspath(diagnostic_message['FilePath']) |
There was a problem hiding this comment.
I think it is safer to use get() method of diagnostic dictionary.
| file_path = os.path.abspath(diagnostic_message['FilePath']) | ||
| file_obj = get_or_create_file(file_path, self._file_cache) | ||
| line, col = get_location_by_offset( | ||
| file_path, diagnostic_message['FileOffset']) |
There was a problem hiding this comment.
diagnostic_message.get("FileOffset") would be better.
| file=file_obj, | ||
| line=line, | ||
| column=col, | ||
| message=diagnostic_message['Message'].strip(), |
Comment on lines
+68
to
+69
| print("res") | ||
| print(res) |
There was a problem hiding this comment.
Are these prints necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently clang-tidy reports are parsed and
converted to plist files from the clang-tidy
standard outputs. This change adds a new
report converter that uses clang-tidy's yaml
outputs as inputs for parsing and
creating plist files.