Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[golang] Enable APPSEC_STANDALONE #3679

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Dec 13, 2024

Motivation

Support for ASM Standalone mode for dd-trace-go. cf. RFC

Changes

  • Remove all "-dev" suffixes of the go manifest
  • Enable APPSEC_STANDALONE tests
  • Implement /requestdownstream and /returnheaders endpoint in go weblogs

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness eliottness force-pushed the eliottness/APPSEC-56100/standalone-asm branch from 1af57ee to fcc4b83 Compare December 18, 2024 16:24
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness eliottness force-pushed the eliottness/APPSEC-56100/standalone-asm branch from de954ef to 29d85bd Compare December 18, 2024 16:51
@eliottness eliottness marked this pull request as ready for review December 18, 2024 17:10
@eliottness eliottness requested review from a team as code owners December 18, 2024 17:10
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci is failing on activated tests

@eliottness
Copy link
Contributor Author

@cbeauchesne it's because the branch on dd-trace-go is not yet merged. I will let you know when we can merge this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants