Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase benchmark validation timeout #4225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 13, 2024

I got this flaky test recently:

  1) Tracing benchmarks tracing_trace runs without raising errors
     Failure/Error: raise('Wait time exhausted!')

     RuntimeError:
       Wait time exhausted!
     # ./spec/support/synchronization_helpers.rb:97:in `try_wait_until'
     # ./spec/support/synchronization_helpers.rb:26:in `expect_in_fork'
     # ./spec/datadog/tracing/validate_benchmarks_spec.rb:19:in `block (4 levels) in <top (required)>'
     # ./spec/datadog/tracing/validate_benchmarks_spec.rb:8:in `block (3 levels) in <top (required)>'
     # ./spec/datadog/tracing/validate_benchmarks_spec.rb:7:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:237:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:122:in `block (2 levels) in <top (required)>'

It looks like this benchmark validation test has a timeout of 10 seconds that was just exceeded in the MacOS CI.

This PR increases it to 30 seconds.

Change log entry
None.

@marcotc marcotc added the dev/internal Other internal work that does not need to be included in the changelog label Dec 13, 2024
@marcotc marcotc requested a review from a team as a code owner December 13, 2024 21:44
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Dec 13, 2024
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 13, 2024

Datadog Report

Branch report: flaky-validate
Commit report: de02684
Test service: dd-trace-rb

✅ 0 Failed, 22100 Passed, 1457 Skipped, 5m 7.47s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (ef81a2f) to head (de02684).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4225      +/-   ##
==========================================
- Coverage   97.75%   97.74%   -0.01%     
==========================================
  Files        1355     1355              
  Lines       82007    82008       +1     
  Branches     4207     4207              
==========================================
- Hits        80164    80161       -3     
- Misses       1843     1847       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 13, 2024

Benchmarks

Benchmark execution time: 2024-12-13 22:05:34

Comparing candidate commit de02684 in PR branch flaky-validate with baseline commit ef81a2f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Copy link
Contributor

@sarahchen6 sarahchen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 flaky test! 🎉

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 +1 Thanks for hunting down this one :)

@@ -16,7 +16,7 @@
benchmarks_to_validate.each do |benchmark|
describe benchmark do
it 'runs without raising errors' do
expect_in_fork do
expect_in_fork(timeout_seconds: 30) do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered a timeout failure in #4207 but I thought my benchmark was taking too long (which still may be the case).

My understanding is the current timeout is 10 seconds, perhaps raising it to 20 would be sufficient rather than going to 30? What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants