-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add byebug to MRI gemfiles #4188
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4188 +/- ##
==========================================
- Coverage 97.75% 97.75% -0.01%
==========================================
Files 1357 1357
Lines 81890 81890
Branches 4164 4164
==========================================
- Hits 80054 80053 -1
- Misses 1836 1837 +1 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-12-03 21:44:49 Comparing candidate commit 3252241 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. I think we've been discussing and exploring a bit the tension between having very minimalistic images for CI vs having tools for development.
I'm not sure we've settled on a balance yet, and I think having byebug be quickly available on short notice seems like a reasonable thing to do.
I have been trying |
What does this PR do?
Adds
byebug
to all of the MRI gemfiles.Motivation:
I use byebug for debugging.
Change log entry
None
Additional Notes:
How to test the change?