Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add byebug to MRI gemfiles #4188

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add byebug to MRI gemfiles #4188

wants to merge 2 commits into from

Conversation

p-datadog
Copy link
Member

What does this PR do?
Adds byebug to all of the MRI gemfiles.

Motivation:
I use byebug for debugging.

Change log entry
None

Additional Notes:

How to test the change?

@p-datadog p-datadog requested a review from a team as a code owner December 3, 2024 19:12
@p-datadog p-datadog added the dev/internal Other internal work that does not need to be included in the changelog label Dec 3, 2024
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 3, 2024

Datadog Report

Branch report: byebug
Commit report: 3252241
Test service: dd-trace-rb

✅ 0 Failed, 22024 Passed, 1458 Skipped, 5m 28.42s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (7f079c9) to head (3252241).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4188      +/-   ##
==========================================
- Coverage   97.75%   97.75%   -0.01%     
==========================================
  Files        1357     1357              
  Lines       81890    81890              
  Branches     4164     4164              
==========================================
- Hits        80054    80053       -1     
- Misses       1836     1837       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 3, 2024

Benchmarks

Benchmark execution time: 2024-12-03 21:44:49

Comparing candidate commit 3252241 in PR branch byebug with baseline commit 7f079c9 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟩 throughput [+0.602op/s; +0.610op/s] or [+10.223%; +10.357%]

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. I think we've been discussing and exploring a bit the tension between having very minimalistic images for CI vs having tools for development.

I'm not sure we've settled on a balance yet, and I think having byebug be quickly available on short notice seems like a reasonable thing to do.

@p-datadog
Copy link
Member Author

I have been trying binding.b for the last couple of days and it seems to work so far, I will continue testing it and perhaps this PR is not needed.

@p-datadog p-datadog marked this pull request as draft December 16, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants