Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Report multiple query errors #4177

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Nov 30, 2024

Change log entry
GraphQL query errors are now reported as Span Events. This includes support for multiple errors, if present.

How to test the change?
All changes are tested.

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Nov 30, 2024
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Nov 30, 2024

Datadog Report

Branch report: graphql-error-event
Commit report: d917334
Test service: dd-trace-rb

✅ 0 Failed, 22046 Passed, 1459 Skipped, 5m 7.94s Total Time

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.75%. Comparing base (28675b6) to head (d917334).

Files with missing lines Patch % Lines
...b/datadog/tracing/contrib/graphql/unified_trace.rb 98.14% 1 Missing ⚠️
...cing/contrib/graphql/support/application_schema.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4177      +/-   ##
==========================================
- Coverage   97.76%   97.75%   -0.01%     
==========================================
  Files        1351     1351              
  Lines       81733    81789      +56     
  Branches     4147     4149       +2     
==========================================
+ Hits        79904    79955      +51     
- Misses       1829     1834       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Nov 30, 2024

Benchmarks

Benchmark execution time: 2024-11-30 00:41:05

Comparing candidate commit d917334 in PR branch graphql-error-event with baseline commit 28675b6 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟩 throughput [+13000.757op/s; +13666.466op/s] or [+6.872%; +7.224%]

scenario:method instrumentation

  • 🟩 throughput [+18322.498op/s; +19148.578op/s] or [+9.172%; +9.586%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants