Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update uri for all dependencies #4090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update uri for all dependencies #4090

wants to merge 1 commit into from

Conversation

TonyCTHsu
Copy link
Contributor

Motivation:

uri (one of the default ruby gems) upgraded, and our lockfiles are stale, failing CI
https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/17411/workflows/f191263c-fc1c-4b65-a5d8-be6ba1549181/jobs/619211

What does this PR do?

Bump uri to the latest version

@TonyCTHsu TonyCTHsu added the dev/testing Involves testing processes (e.g. RSpec) label Nov 8, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review November 8, 2024 11:45
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 8, 2024 11:45
@TonyCTHsu TonyCTHsu enabled auto-merge November 8, 2024 11:46
Strech
Strech approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TonyCTHsu TonyCTHsu disabled auto-merge November 8, 2024 11:55
@pr-commenter
Copy link

pr-commenter bot commented Nov 8, 2024

Benchmarks

Benchmark execution time: 2024-11-08 12:15:26

Comparing candidate commit 1fe9bb3 in PR branch tonycthsu/update-uri with baseline commit c8bd1e4 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.515op/s; -0.507op/s] or [-7.606%; -7.475%]

@ivoanjo
Copy link
Member

ivoanjo commented Dec 9, 2024

Hey @TonyCTHsu any reason not to merge this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpellan vpellan vpellan approved these changes

@delner delner delner approved these changes

@Strech Strech Strech approved these changes

Assignees
No one assigned
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TonyCTHsu @ivoanjo @Strech @delner @vpellan