sample before propagation, context switching, and writing #3866
+40
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZStriker19
commented
Aug 30, 2024
…dd-trace-rb into zachg/sample_before_propagation
|
Hey @ZStriker19 is still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change is so that sampling will be performed as late as possible for a trace. This gives us the greatest amount of information we can have on a trace available (namely tags and resource name) to choose if that trace should be sampled or not.
Motivation:
Bring Ruby tracer in line with other tracers and allow further user fine grain control over sampling.
How to test the change?
Unsure? Have a question? Request a review!