Added more FMA functions with tests #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8, _mm_fmadd_ps, _mm_addsub_ps, _mm_load_pd _mm_loadu_pd, _mm_store_pd, _mm_storeu_pd
marktwtn
reviewed
Jul 26, 2020
marktwtn
reviewed
Jul 26, 2020
marktwtn
reviewed
Jul 26, 2020
marktwtn
reviewed
Jul 26, 2020
marktwtn
approved these changes
Jul 27, 2020
|
Header |
|
Can we use something like "ifdef USE_FMA"‚ and enable only for those who want it? |
jserv
force-pushed
the
master
branch
3 times, most recently
from
eb8e6ef to
c902b5e
Compare
|
Let's close this pull request in favor of #82. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the last split of the original #83.
I have added fmsub_ps, fmnadd_ps, fmnsub_ps, and the associated tests.
I had to lower the input vector in the test functions and use an epsilon of 0.0001f because those functions are less precise than just using mul and add, and they seem to diverge with big float numbers (I use qemu, it might be worth checking on real hardware).