Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(regex tester): optional groups/captures failing #1391

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sharevb
Copy link
Contributor

@sharevb sharevb commented Nov 17, 2024

Fix #1388

Copy link

vercel bot commented Nov 17, 2024

@sharevb is attempting to deploy a commit to the Corentin Thomasset's Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

sonarcloud bot commented Nov 17, 2024

@sharevb sharevb marked this pull request as ready for review November 17, 2024 21:20
@@ -92,6 +92,51 @@ const regexesData = [
},
],
},
{
regex: '\\s([^\\s\\[]+)(?:\\[(\\d+)\\])?:\\s',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use String.raw to make this easier to check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, yes, may be clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regex tester fails with optional group
2 participants