feat: Assign imported posts to categories based on the keywords #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HardeepAsrani
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
Comment on lines
+678
to
+684
| $auto_categories = array_filter( $auto_categories, function( $item ) { | ||
| if ( ! empty( $item['keywords'] ) && is_numeric( $item['category'] ) ) { | ||
| $item['keywords'] = sanitize_text_field( $item['keywords'] ); | ||
| return true; | ||
| } | ||
| return false; | ||
| } ); |
There was a problem hiding this comment.
I think it is better to have a separate context here. A filter should filter the items, a map should modify the items.
$auto_categories = array_filter( $auto_categories, function( $item ) {
return ! empty( $item['keywords'] ) && is_numeric( $item['category'] );
});
$auto_categories = array_map(function( $item ) {
$item['keywords'] = sanitize_text_field( $item['keywords'] );
return $item;
}, $auto_categories);| <div class="help-text pt-8"> | ||
| <?php | ||
| printf( | ||
| // translators: %s is a placeholder for the auto categories tag. |
There was a problem hiding this comment.
One tip here is to include the actual value in the translator's comment to give them a better context. You can append it like this (like "[#auto_categories]").
Soare-Robert-Daniel
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Information here: https://github.com/Codeinwp/feedzy-rss-feeds-pro/pull/802
Check before Pull Request is ready:
Closes #https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/768.