Item name is not inherited with copy-from

[Uwuewsky]

Is your feature request related to a problem? Please describe.

Item names are not inherited, requiring this field to be copied manually. This can cause problems if the original name has changed.

For example, this one won't work:

Cataclysm-DDA/data/mods/BombasticPerks/perkdata/old_guns.json

Lines 233 to 239 in 13c7a44

	{
	"id": "shotgun_410",
	"type": "GUN",
	"copy-from": "shotgun_410",
	"name": { "str": "Winchester M37 .410" },
	"extend": { "flags": [ "OLD_GUN" ] }
	},

  {
    "id": "shotgun_410",
    "type": "GUN",
    "copy-from": "shotgun_410",
-   "name": { "str": "Winchester M37 .410" },
    "extend": { "flags": [ "OLD_GUN" ] }
  },

 DEBUG    : Error: Json error: data/mods/BombasticPerks/perkdata/old_guns.json:239:5: <color_white><color_cyan>name unspecified for item type</color>
 FUNCTION : bool main_menu::new_character_tab()
 FILE     : src/main_menu.cpp
 LINE     : 1153
 VERSION  : cdda-experimental-2024-12-18-0250 c085521

Solution you would like.

Make it so that the name is also copied from the parent definition.

Describe alternatives you have considered.

No response

Additional context

Right now, for monsters, both name and description can be inherited:

Cataclysm-DDA/data/mods/Xedra_Evolved/monsters/monster_overrides.json

Lines 2 to 7 in 13c7a44

	{
	"type": "MONSTER",
	"id": "mon_tindalos",
	"copy-from": "mon_tindalos",
	"extend": { "flags": [ "STABILIZED_TIMELINE" ] }
	},

For items only descriptions is inherited. I don't know if there is any reason for this restriction.

Cataclysm-DDA/src/item_factory.cpp

Lines 4287 to 4294 in 13c7a44

	def.name = translation( translation::plural_tag() );
	if( !jo.read( "name", def.name ) ) {
	jo.throw_error( "name unspecified for item type" );
	}
	if( jo.has_member( "description" ) ) {
	jo.read( "description", def.description );
	}

[Karol1223]

Relevant: #71199 and #71195