feat/cef audio v2 #1590
Draft
feat/cef audio v2 #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #1517 (feat/cef-audio) with fix for 16 channels
This (almost) works for me in windows. It sounds like the first packet of samples goes to the system instead of being routed to the html_client, other than that it sounds fine now. I don't have that issue in linux, where it works flawlessly now (with very little testing though).
I'm not too fond of the frame flow yet. It feels very convoluted. I have another version on my linux branch that I like more. I'll try to cherry-pick that and add to this PR. I'd like to hear what you thinkAdded the frame flow refactoring. I think this is much simpler.