Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
handle_error
, and thus theVACKUP_FAILURE_SCRIPT
script as well, is only called if an executed command exits with an error. They are not called when the script exits with its own error, for example:echo "Error: Volume $VOLUME_NAME does not exist"; exit 1
. This PR adds a newerror
function that ensures thehandle_error
function is called at the end with the correct caller line number, and changes everyexit 1
call in the script toerror
instead.Also fixed the inconsistency in the "Volume $VOLUME_NAME does not exist, creating..." message and changed it into a wanring instead of an error:
and