Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass fp cred to the dynamic validator for miwi flow #4016

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pass fp cred to the dynamic validator for miwi flow #4016

wants to merge 1 commit into from

Conversation

rajdeepc2792
Copy link
Collaborator

Which issue this PR addresses:

Fixes Azure Client Action failure due to missing FP Creds during MIWI Dynamic Valdiations.
This was caused due to changes done in #3889

What this PR does / why we need it:

Pass a fp Credential while initializing dynamic validator for the managed identities.
This allows an authorizer header to be passed for calls to ARM.

Test plan for issue:

  • Tested Local Cluster Creation
  • No test case to test the authorization failures

Is there any documentation that needs to be updated for this PR?

No

How do you know this will function as expected in production?

  • MIWI not available in prod currently, need to be tested in Canary.

@rajdeepc2792 rajdeepc2792 self-assigned this Dec 13, 2024
@rajdeepc2792 rajdeepc2792 added size-small Size small ready-for-review chainsaw Pull requests or issues owned by Team Chainsaw labels Dec 13, 2024
@cadenmarchese cadenmarchese added the next-release To be included in the next RP release rollout label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawande2 slawande2 slawande2 approved these changes

@cadenmarchese cadenmarchese cadenmarchese approved these changes

@tsatam tsatam tsatam approved these changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@jaitaiwan jaitaiwan Awaiting requested review from jaitaiwan jaitaiwan is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig is a code owner

@tiguelu tiguelu Awaiting requested review from tiguelu tiguelu is a code owner

@mociarain mociarain Awaiting requested review from mociarain mociarain is a code owner

@kimorris27 kimorris27 Awaiting requested review from kimorris27 kimorris27 is a code owner

@bitoku bitoku Awaiting requested review from bitoku bitoku is a code owner

@fahlmant fahlmant Awaiting requested review from fahlmant fahlmant is a code owner

Assignees

@rajdeepc2792 rajdeepc2792

Labels
chainsaw Pull requests or issues owned by Team Chainsaw next-release To be included in the next RP release rollout ready-for-review size-small Size small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajdeepc2792 @tsatam @cadenmarchese @slawande2