This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Change how encoding is specified #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Apparently on macOS Ruby has different command line arguments from all the other OS's, thankfully it seems the --external-encoding and --internal-encoding options are the same, and the -Eutf-8 that was in use before is equivalent to setting both of those anyway.
Arcanemagus
force-pushed
the
arcanemagus/fix-encoding-specification
branch
from
8d0334d to
4a1d6ad
Compare
|
As this is a slight compatibility improvement, I'm merging this anyway, even though it doesn't help with the odd macOS users. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently on macOS Ruby has different command line arguments from all the other OS's, thankfully it seems the
--external-encodingand--internal-encodingoptions are the same, and the-Eutf-8(-E utf-8on macOS...) that was in use before is equivalent to setting both of those anyway.