Merge pull request #124 from vzamanillo/use-activationhooks

Switch to scope activationHook from language package

lib/linter-reek.js

@@ -91,7 +91,11 @@ export default {
   provideLinter() {
     return {
       name: 'reek',
-      grammarScopes: ['source.ruby', 'source.ruby.rails', 'source.ruby.rspec'],
+      grammarScopes: [
+        'source.ruby',
+        'source.ruby.rails',
+        'source.ruby.rspec',
+      ],
       scope: 'file',
       lintsOnChange: false,
       lint: async (editor) => {

package.json

@@ -13,6 +13,11 @@
       "default": "reek"
     }
   },
+  "activationHooks": [
+    "source.ruby:root-scope-used",
+    "source.ruby.rails:root-scope-used",
+    "source.ruby.rspec:root-scope-used"
+  ],
   "engines": {
     "atom": ">=1.7.0 <2.0.0"
   },

spec/linter-reek-spec.js

@@ -14,8 +14,22 @@ const badFile = path.join(__dirname, 'fixtures', 'bad.rb');
 describe('The reek provider for Linter', () => {
   beforeEach(async () => {
     atom.workspace.destroyActivePaneItem();
+
+    const activationPromise = atom.packages.activatePackage('linter-reek');
+
     await atom.packages.activatePackage('language-ruby');
-    await atom.packages.activatePackage('linter-reek');
+    await atom.workspace.open(goodFile);
+
+    atom.packages.triggerDeferredActivationHooks();
+    await activationPromise;
+  });
+
+  it('should be in the packages list', () => {
+    expect(atom.packages.isPackageLoaded('linter-reek')).toBe(true);
+  });
+
+  it('should be an active package', () => {
+    expect(atom.packages.isPackageActive('linter-reek')).toBe(true);
   });
 
   it('checks a file with issues and reports the correct message', async () => {