Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovering over blocks with a selection displays the selection #10323

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

MEEPofFaith
Copy link
Contributor

Based off of a post in #pulls.

20241113-220534-java.mp4

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

@MEEPofFaith
Copy link
Contributor Author

I'm not sure whether the drawItemSelection method should go in building or block.

@JasonP01
Copy link
Contributor

This should be a setting, im sure some people would rather not have this interaction. Simple setting in graphics as it is an accessibility option

@MEEPofFaith
Copy link
Contributor Author

MEEPofFaith commented Nov 14, 2024

This should be a setting, im sure some people would rather not have this interaction. Simple setting in graphics as it is an accessibility option

Should it go under Game or Graphics?
Graphics, probably.

@MEEPofFaith MEEPofFaith reopened this Nov 14, 2024
@MEEPofFaith
Copy link
Contributor Author

oops

@JasonP01
Copy link
Contributor

I said graphics in the same comment 💀

Probably needs a better name
@JasonP01
Copy link
Contributor

Game would effect anything that changes core aspects, like auto target on mobile changes the way you interact with enemies, or autosave or double tap to mine. Core aspects are changed

Graphics are purely visual changes which whether enabled or disabled dont change the game in any concernable way, you will still be able to play the game normally (tho maybe a little harder in some aspects) without it

@JasonP01
Copy link
Contributor

JasonP01 commented Nov 14, 2024

Also as for better name, more specific would do

"Show block config's on hover"

Gets to the point quickly and is informative as to what it does

BlueTheCube

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants