Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed scaffold with navigation which was causing logout button was vanishing in tablet mode #199

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

HelloSniperMonkey
Copy link

Description

This PR addresses the issue which appears when the app is being used on tablets or with device width 451 and 800 and on apps with resizable window size

  • added the logout button when the device width is in the given range
  • linked it logically to the firebase authenticator to logout user when the button is clicked

this fixes the issue when the user is using the app on tablet or at specified resolution and now is able to logout completely without hassle

Fixes #194

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • tested it on browser , macos and iphone , ipad simulator for various device widths and had no issue on those

###Please include screenshots below if applicable.

Screen.Recording.2024-12-17.at.10.30.27.PM.mov

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@HelloSniperMonkey
Copy link
Author

Can you please review ? @mdmohsin7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect navigation bar on tab size view
1 participant