Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint #1648

Open
1 task done
florian-sanders opened this issue Nov 9, 2024 · 0 comments · May be fixed by #1732
Open
1 task done

Stylelint #1648

florian-sanders opened this issue Nov 9, 2024 · 0 comments · May be fixed by #1732
Labels
language A request to add a language extension

Comments

@florian-sanders
Copy link

florian-sanders commented Nov 9, 2024

Check for existing issues

  • Completed

Language

CSS, SCSS, css-in-js

Tree Sitter parser link

No response

Language server link

https://github.com/stylelint/vscode-stylelint

Misc notes

Context

I am currently working on a zed-stylelint extension.

The extension seems to work properly but I still consider it Work In Progress for several reasons:

  • I'm a beginner with Rust,
  • I haven't tested all use-cases, only mines for now (css-in-js mostly),
  • The extension relies on a fork of the stylelint/vscode-stylelint. The main reasons I need a fork is because:
    • The VSCode extension provides an LSP implementation but it's not published as a standalone project so I have to pull the code of both the VSCode extension and the server itself even though I only need the server part,
    • The VSCode extension is not published on npm and only publishes the source code on the repo. Since it's a TypeScript project it needs to be built + bundled and I couldn't find how to run npm commands that are async from the zed_extension_api 🤔
    • The fork contains the same code as the original repo + the built & bundled code so it can be downloaded by the zed extension to be used directly.
  • I've asked the repo of the VSCode extension if my fork was acceptable for them and if they plan on extracting the language server or at least publish the bundled code to npm so I don't have to maintain a fork (see stylelint/vscode-stylelint #623.

It seems the Sublime text Stylelint extension also has the same strategy of bundling the VSCode extension code: https://github.com/sublimelsp/LSP-stylelint/tree/master/language-server

Questions

  • Are other users interested by this Extension? Add 👍 if you are!
  • Is the fact that the extension relies on a fork of a VSCode extension a blocker to make it official? Would be nice to get some input about that from someone at Zed Industries but it can be discussed in the PR.

Other Zed users asking for Stylelint LSP

Couldn't find much but Stylelint was mentionned in zed-industrices/zed #5612

@florian-sanders florian-sanders added the language A request to add a language extension label Nov 9, 2024
florian-sanders added a commit to florian-sanders/extensions that referenced this issue Nov 29, 2024
@florian-sanders florian-sanders linked a pull request Nov 29, 2024 that will close this issue
florian-sanders added a commit to florian-sanders/extensions that referenced this issue Nov 29, 2024
florian-sanders added a commit to florian-sanders/extensions that referenced this issue Nov 30, 2024
florian-sanders added a commit to florian-sanders/extensions that referenced this issue Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language A request to add a language extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant