How to correctly specify a return type of getLogs?

[benesjan]

Hello, how would I specify a return type of getLogs?

[fubhy]

Normally, you shouldn't need to explicitly specifiy generic type variables yourself. The return type should be automatically inferred from the given abi & client instance.

Can you create a reproduction (e.g. stackblitz.com) if that isn't working for you?

[fubhy]

I suspect that you are also assigning a type to this.publicClient. If you are doing that, and not doing it correctly (e.g. PublicClient<TTransport, TChain>, then the getLogs won't be able to infer the type for you.

[benesjan]

Hello, when I do replaced

    return await this.publicClient.getLogs({
      address: getAddress(this.rollupAddress.toString()),
      event: getAbiItem({
          abi: RollupAbi,
          name: 'L2BlockProcessed',
      }),
      fromBlock,
      toBlock,
    });

with

    const abiItem = getAbiItem({
      abi: RollupAbi,
      name: 'L2BlockProcessed',
    });
    return await this.publicClient.getLogs({
      address: getAddress(this.rollupAddress.toString()),
      event: abiItem,
      fromBlock,
      toBlock,
    });

the return type got inferred correctly.

The abi is defined here and the code where we use it is here. Do you see something wrong with the abi? If not I am fine with the solution we've came up with. Thank you for your help

[tmm]

Looks like the issue is internally we aren't narrowing event (e.g. TAbiEvent) so event defined inline doesn't work. Updated in this PR #363

[fubhy]

Ok well that's a bug. And I can see where... I'll create a PR shortly.

Didn't see your message! Beat me to it :-)

[tmm]

Already fixed it here: #363

[fubhy]

Beat me to it!