Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible missing "toList" in algebra example #136

Open
afs opened this issue Feb 12, 2024 · 4 comments
Open

Possible missing "toList" in algebra example #136

afs opened this issue Feb 12, 2024 · 4 comments
Labels
Errata Errata management: confirmed erratum spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text)

Comments

@afs
Copy link
Contributor

afs commented Feb 12, 2024

Issue mentioned on StackOverflow

https://stackoverflow.com/questions/77978291/sparql-1-1-algebra-converting-multiset-to-sequence

@afs afs added Errata Errata management: confirmed erratum spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text) labels Feb 12, 2024
@afs
Copy link
Contributor Author

afs commented Feb 17, 2024

@hartig
Copy link
Contributor

hartig commented Feb 22, 2024

I agree with the proposed change in the first Stack Overflow question. That is, the input to the Project operator in this example must be wrapped in a ToList operator.

By the way, the example that this question talks about feels a bit out of place in Section 18.2.3 because, in contrast to all the other examples in this section, the example in question requires translation steps that are defined later, in Sections 18.2.4 and 18.2.5.

@hartig
Copy link
Contributor

hartig commented Feb 22, 2024

Regarding the second Stack Overflow question mentioned above, the observation in that question is right (yes, ToList must be applied) but there is actually no bug in the spec. Instead, adding the ToList operator is a step that is required before translating the solution modifiers, as defined in Section 18.2.5.

Having said that, I think that the fact that adding the ToList operator is a required step is not so clear in the spec.

I will create a PR that fixes both issue.

@hartig
Copy link
Contributor

hartig commented Mar 22, 2024

@afs I think this issue can be closed now.
Also, feel free to leave a comment about it in the two Stack Overflow questions (I don't have an account there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Errata Errata management: confirmed erratum spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text)
Projects
None yet
Development

No branches or pull requests

2 participants