Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding menubar and toolbar to fieldset #400

Open
scottaohara opened this issue Feb 2, 2022 · 1 comment · May be fixed by #442
Open

Consider adding menubar and toolbar to fieldset #400

scottaohara opened this issue Feb 2, 2022 · 1 comment · May be fixed by #442
Assignees
Labels
Allowed roles Pertaining to the allowed roles of HTML elements

Comments

@scottaohara
Copy link
Member

Semantically being groupings of related controls, it makes sense that a fieldset would allow for these roles that have a similar purpose.

Additionally, at least with some quick testing, a legend within a fieldset with one of these roles would allow a naming mechanism without use of aria-label or aria-labelledby. Would want to test this more, but would expect similar results to #350

@scottaohara scottaohara added the Allowed roles Pertaining to the allowed roles of HTML elements label Feb 2, 2022
@scottaohara scottaohara added this to the ARIA in HTML: Next milestone Feb 2, 2022
@scottaohara scottaohara self-assigned this Mar 3, 2022
@scottaohara
Copy link
Member Author

test cases and notes on behaviors - https://codepen.io/scottohara/pen/ExpaeEj

outside of some minor oddities with Safari/VO (bug filed for iOS), it seems to me that fieldset should allow the following roles:

  • toolbar
  • menubar
  • menu
  • listbox
  • tablist
  • article
  • dialog
  • region (this is the role that has the most odd behaviors with it, but none of which are going to cause blocking issues, and further modifications could mitigate them entirely - e.g., not using legend to attempt to name the element).

scottaohara added a commit that referenced this issue Dec 21, 2022
closes #400

Updates allowances for the toolbar, menubar, menu, listbox, tablist, article, dialog and region roles to be used on the fieldset element.
@scottaohara scottaohara linked a pull request Dec 21, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Allowed roles Pertaining to the allowed roles of HTML elements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant