-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
popovertargetaction=show/hide when popover is already shown or hidden #505
Comments
I think that it should not have disabled. Since wouldn't the state of if the popover's shown or not be conveyed through But on a slightly different topic, if there's a To better understand what I mean: <div id="p" popover> <!--Popover is shown-->
<button popovertarget="p">Close</button>
<button popovertarget="p" popovertargetaction="toggle">Close</button>
<button popovertarget="p" popovertargetaction="hide">Close</button>
<!--These all should have `aria-expanded=undefined`-->
</div> |
Sounds like this is identical in functionality to |
A few real-world use cases that seem like they would be harmed by this come to mind:
I could be misunderstanding how to use I'm also generally leery of browsers magically marking a trigger semantically disabled while the author still thinks the trigger is enabled, and while the trigger is enabled for anyone not using a screen reader. I'd rather take the stance that authors are responsible for deciding whether the element is enabled or disabled equally for everyone. |
unless anyone has any compelling use cases that couldn't arguably be redesigned to mitigate issues of buttons that don't 'do anything', it seems like the answer from today's call was "no" don't automatically do this. I think from @YummyBacon5's example, the only thing not covered in the current PR (#481) is to potentially set the close 'toggle' button that is a descendant of the parent popover should instead have aria-expanded=undefined as well. |
Minutes for today's meeting: https://www.w3.org/2023/10/12-aria-minutes.html#t05 |
Thoughts on whether this should be exposed as 'disabled' in the accessibility API - since the button won't actually do anything if the popover is in the state that matches the action value.
The text was updated successfully, but these errors were encountered: