-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember enrolled courses #130
Comments
It would be practical for accounts having few hundred courses but if an account has around 4000 courses enrolled it would take a lot of time to start up and update the local database. Let me your stance on the comment. |
It could be an optional feature, retrieving the list of already enrolled courses (which will be a few requests), vs testing hundreds of courses at every launch (all courses in a language) |
@sebbu2 The current implementation fetches all enrolled course IDs immediately after login. However, there's a performance bottleneck, and It can be solved by using threading. Regarding saving a DB type file, I was initially hesitant about adding another file to the project. However, after consideration, adding this functionality might actually improve the speeds and reduce API calls. I'll run some tests to validate this approach. |
It seems there was a difference between the CLI and GUI version. In 2.3.1 both do remember enrolled courses. They don't remember filtered or courses (due to language for example) though, which still means some requests/time consumption. |
I don't want to retry every time the same courses when I know I am enrolled it.
Sugestion:
Create a local storage with my enrolled courses, only when Udemy response it first time.
Regards!
The text was updated successfully, but these errors were encountered: