Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember enrolled courses #130

Open
jonathanhecl opened this issue Nov 7, 2022 · 4 comments
Open

Remember enrolled courses #130

jonathanhecl opened this issue Nov 7, 2022 · 4 comments
Labels
Status: Discussion In discussion Type: Enhancement New feature or request

Comments

@jonathanhecl
Copy link

I don't want to retry every time the same courses when I know I am enrolled it.

Sugestion:
Create a local storage with my enrolled courses, only when Udemy response it first time.

Regards!

@jonathanhecl jonathanhecl added the Type: Enhancement New feature or request label Nov 7, 2022
@techtanic
Copy link
Owner

It would be practical for accounts having few hundred courses but if an account has around 4000 courses enrolled it would take a lot of time to start up and update the local database.

Let me your stance on the comment.
Thank you.

@techtanic techtanic added the Status: Awaiting Response Waiting for a response/more information. label Jan 10, 2023
@techtanic techtanic added Status: Awaiting Response Waiting for a response/more information. Status: No Response and removed Status: Awaiting Response Waiting for a response/more information. labels Apr 19, 2023
@techtanic techtanic closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2023
@sebbu2
Copy link

sebbu2 commented Nov 2, 2024

It could be an optional feature, retrieving the list of already enrolled courses (which will be a few requests), vs testing hundreds of courses at every launch (all courses in a language)

@techtanic
Copy link
Owner

@sebbu2 The current implementation fetches all enrolled course IDs immediately after login. However, there's a performance bottleneck, and It can be solved by using threading.

Regarding saving a DB type file, I was initially hesitant about adding another file to the project. However, after consideration, adding this functionality might actually improve the speeds and reduce API calls. I'll run some tests to validate this approach.

@sebbu2
Copy link

sebbu2 commented Nov 11, 2024

It seems there was a difference between the CLI and GUI version.

In 2.3.1 both do remember enrolled courses. They don't remember filtered or courses (due to language for example) though, which still means some requests/time consumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Discussion In discussion Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants