Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to how stars are rendered has broken my rotating starry sky animation #64

Open
vesper8 opened this issue Dec 29, 2019 · 1 comment

Comments

@vesper8
Copy link

vesper8 commented Dec 29, 2019

I was manually importing an old version of your aframe-environment-component.min.js where I guess you were painting the entire night sky full of stars.

I created a day/night cycle where the sun rises in the west and sets in the east and then during night there's a rotation animation happening which looks just beautiful if you ask me.

I now decided to update my dependencies and I tried using your 1.1.0 (the 2.0 for some reason does not animate my sun at all anymore). Using the 1.1.0 version I see that you are only drawing stars on part of the sky, which results in the sky staying half empty/half full of stars during my rotation animation

I would like if you could introduce an option to paint the entire sky (even the non-visible area) so I can use your latest version.

Not sure if this is related #45

Could you please add an option to draw stars onto the entire sky not just the visible sky? Like it used to do before

If you want to see what my day/night cycle looks like (this is using the older version of this component) check it out here: https://vr.mad.social

Using 1.1.0 it's the same but half the sky is starless (black)

Using 2.0 the sun doesn't animate at all.. if you have any idea why would love to hear it!

I noticed that 2.0 isn't mentioned anywhere here on Github but it is the latest tagged release on https://www.npmjs.com/package/aframe-environment-component

Many thanks!

@kylebakerio
Copy link
Contributor

for something like this, one should just borrow source code and build according to your own needs. That saide, iirc, the new 1.2.0 method for making stars does paint dots around the entire sphere, I believe. This is technically not generally a great idea, as those generally invisible points are wasted resources (since this environment doesn't rotate.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants