Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tests to Music Blocks codebase. #4124

Open
2 of 6 tasks
apsinghdev opened this issue Dec 9, 2024 · 10 comments
Open
2 of 6 tasks

Implement tests to Music Blocks codebase. #4124

apsinghdev opened this issue Dec 9, 2024 · 10 comments

Comments

@apsinghdev
Copy link
Member

apsinghdev commented Dec 9, 2024

Current Behavior

Currently, we don't have tests in Music Blocks codebase.

Desired Situation

It would be a better idea to include tests in musicblocks codebase for a robust and fast testing workflow so that we don't rely on testing functionalities manually and we avoid breaking changes in production.

In the last meeting, we agreed on using Jest and Cypress to create tests but I am inviting the community to provide their feedbacks on it.

Files to implement tests to (We will keep on adding more files here)

Utils

  • mathutils.js
  • munsell.js
  • musicutils.js (challenging)
  • platformstyle.js
  • synthutils.js (challenging)
  • utils.js

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@BeNikk
Copy link
Contributor

BeNikk commented Dec 9, 2024

Jest and Cypress seem like great choices for testing, are we planning to have a specific folder structure for keeping the test files, or will there be a centralised test folder having all the test files?

@walterbender
Copy link
Member

I am thinking that the tests could be kept in folders for each subdirectory of the code, e.g. js/utils/tests, js/blocks/tests, etc.

@Aman1919
Copy link
Contributor

Could I also contribute to this, @walterbender?

@walterbender
Copy link
Member

Anyone/everyone is welcome to contribute.

@Commanderk3
Copy link
Contributor

Commanderk3 commented Dec 13, 2024

I am about to finish musicutils.test.js
If anyone interested in collab feel free to reach me. Otherwise don't start from scratch.

@Aman1919
Copy link
Contributor

@Commanderk3 I like to collaborate! How do you suggest we move forward. I am also on matrix group?

@Commanderk3
Copy link
Contributor

@Commanderk3 I like to collaborate! How do you suggest we move forward. I am also on matrix group?

Cool @Aman1919 , DM me. User name : Diwangshu Kakoty.
I will reply to you in the morning 👍

@apsinghdev
Copy link
Member Author

apsinghdev commented Dec 14, 2024

Hi everyone, I am starting to add tests to platformstyle.js and synthutils.js. Please consider it while picking a file to add tests to so that it doesn't conflict. Thanks! 🙂

walterbender pushed a commit that referenced this issue Dec 14, 2024
* Update 2

* dk

* musicutil final

* update

* final update

* comment lines removed
@walterbender
Copy link
Member

As per our discussion, we will hold off on DOM-related tests until we sort out some dependency issues.

@ravjot07
Copy link

I have added test for utils.js......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants