Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: document WasmEdge version dependency #152

Closed

Conversation

LauraLangdon
Copy link
Contributor

Closes #145. I copied the callout syntax from another page of ours, and maybe it's specific to Docusaurus because it doesn't display as a callout box with regular Markdown?

@flaki
Copy link
Contributor

flaki commented Jul 12, 2022

Hmm this is a bit weird to me just blurted out like that.

We have this in the "Reactr ❤️ WebAssembly" page:

By default, Reactr uses the Wasmer runtime internally, but supports the Wasmtime runtime as well. Pass -tags wasmtime to any go command to use Wasmtime. Wasmtime is not yet supported on ARM.

Could we perhaps move that side note into the main page / install instructions? Then this dependency would make a lot more sense IMO.

@LauraLangdon
Copy link
Contributor Author

LauraLangdon commented Jul 12, 2022

Could we perhaps move that side note into the main page / install instructions? Then this dependency would make a lot more sense IMO.

Isn't this the install page for Reactr?

@flaki
Copy link
Contributor

flaki commented Jul 13, 2022

Could we perhaps move that side note into the main page / install instructions? Then this dependency would make a lot more sense IMO.

Isn't this the install page for Reactr?

I meant, could we move the bit I quoted from the Reactor <3 WebAssembly page into the one you edited in this PR to give the note you added more context?

As Reactr can be used with any number of engine backends, and WasmEdge isn't even the default one, that would add more context ("if you do want to use WasmEdge you need to explicitly say so -- and in that case you should use a specific version of it").

@LauraLangdon
Copy link
Contributor Author

Could we perhaps move that side note into the main page / install instructions? Then this dependency would make a lot more sense IMO.

Isn't this the install page for Reactr?

I meant, could we move the bit I quoted from the Reactor <3 WebAssembly page into the one you edited in this PR to give the note you added more context?

As Reactr can be used with any number of engine backends, and WasmEdge isn't even the default one, that would add more context ("if you do want to use WasmEdge you need to explicitly say so -- and in that case you should use a specific version of it").

Gotcha! Yep, that makes total sense!

@LauraLangdon LauraLangdon requested a review from ospencer July 14, 2022 22:16
@LauraLangdon
Copy link
Contributor Author

Closing due to the impending deprecation of Reactr.

@LauraLangdon LauraLangdon deleted the laura/145-document-dependency-on-wasmedge-gov09 branch November 25, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document dependency on [email protected]
2 participants