Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: unhandled wallet account email with trailing whitespaces on PaymentRequest for Apple/Google Pay integration #377

Open
ivanwidj opened this issue Jan 19, 2023 · 5 comments
Labels
bug Something isn't working pinned

Comments

@ivanwidj
Copy link

What happened?

When using PaymentRequest to handle apple/google pay integration, create payment_method (POST v1/payment_methods) might fail if the email address from the wallet account is invalid (e.g. having trailing whitespaces [email protected] ).

Though these kind of emails seem to have already been caught/handled on newly created wallet accounts, in live/prod scenarios a small percentage of old accounts still have email addresses with trailing whitespaces.

A proposed solution is to trim trailing whitespaces from email address value before using it on billing_details.email when creating payment method within PaymentRequest flow

Environment

No response

Reproduction

No response

@ivanwidj ivanwidj added the bug Something isn't working label Jan 19, 2023
@stale
Copy link

stale bot commented Feb 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 9, 2023
@stale stale bot closed this as completed Feb 17, 2023
@martinalong-stripe
Copy link
Contributor

Thanks for flagging this! We've added it to our roadmap to trim whitespaces from emails before returning them

@frenchie048
Copy link

Hi there! Any updates on this @martinalong-stripe?

@ivanwidj
Copy link
Author

ivanwidj commented Aug 8, 2024

Any update on this bug @martinalong-stripe?
also please let me know if this bug is more appropriate to be raised on https://github.com/stripe/stripe-js instead

@brendanm-stripe
Copy link

Hey @ivanwidj -- no update to share here but I would suggest writing in to support as well, describing this problem, sharing a link to this issue and ideally including examples of failed payments/PM creation requests as a result.

Support: https://support.stripe.com/contact

This way we can associate your Stripe account to our internal record of the issue for any follow ups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pinned
Projects
None yet
Development

No branches or pull requests

5 participants