Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusion about next and current event #1084

Open
richardboehme opened this issue Nov 29, 2024 · 2 comments · May be fixed by #1087
Open

Confusion about next and current event #1084

richardboehme opened this issue Nov 29, 2024 · 2 comments · May be fixed by #1087

Comments

@richardboehme
Copy link
Contributor

Hey! We've just published our next meetup which is still some time away (more than 3 months ago). After our current event was over I was expecting that the next event will be "promoted" on the homepage of the user group. However, it does not show the next event but the custom recurrence text of the user group.

I've already inspected the code on why this is happening and I'm not sure if I understand the reasoning behind the implementation. Basically we look for the "current event" which is implemented using the current scope in the Event model. This scope specifically looks for events that take place in the next 9 weeks. The number feels quite arbitrary to me and I feel like just changing this to display the next planned event (with min date in the future) should work best for frequent and less frequent meetups. But maybe there is a special reason why we want to enforce a specific actuality?

Another option I could think of is to let admins control which event should be "promoted" on the home page, however this might become tedious to manage and would need some UI on the admin page.

Let me know what you think and if you're open to change the behavior.
@phoet
Copy link
Member

phoet commented Nov 30, 2024

I guess that this was tailored to our Meetup schedule, but not sure exactly.

@richardboehme
Copy link
Contributor Author

I guess that this was tailored to our Meetup schedule, but not sure exactly.

Yeah I guess so, it was also changed once because the cologne.rb meeting was 9 weeks in the future :D

richardboehme added a commit to richardboehme/on_ruby that referenced this issue Dec 3, 2024
@richardboehme
Use next event as the "current" event
b8a42e9 
This change removes the restriction of the current event to be at most 9
weeks in the future. Some user groups might decide to hold meetups less
frequently so this limitation prevents them from advertising their next
event until 9 weeks before the meetup.

With this change the current event that is displayed on the homepage
will always be the next event, even if it's set far in the future.

Closes rughh#1084
@richardboehme richardboehme linked a pull request Dec 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use next event as the "current" event richardboehme/on_ruby
2 participants
@phoet @richardboehme