Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XipCs1 function #7

Open
thejpster opened this issue Nov 13, 2024 · 4 comments
Open

Add XipCs1 function #7

thejpster opened this issue Nov 13, 2024 · 4 comments

Comments

@thejpster
Copy link
Member

It's FUNCSEL 9

@jonathanpallant
Copy link

OK, so the problem is the FuncSel value of 9 does different things depending on the pin. But we've flattened it into one enum to cover all the pins.

image

I guess we could call number 9 CS1_CLOCK_TRACE?

@jannic
Copy link
Member

jannic commented Nov 13, 2024

There's already an entry for funcsel 9 in the PAC:

      #[doc = "9: Connect to GPCK peripheral"]
      GPCK = 9,

We can't have multiple variants with the same numeric value, so all we could do is rename this variant.

@jonathanpallant
Copy link

Yup

@thejpster
Copy link
Member Author

So I think we just leave this and fix it in the HAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants