Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect actions that are pinned to master/main #435

Open
jmeickle-theaiinstitute opened this issue Jun 18, 2024 · 1 comment
Open

Detect actions that are pinned to master/main #435

jmeickle-theaiinstitute opened this issue Jun 18, 2024 · 1 comment

Comments

@jmeickle-theaiinstitute

I updated actionlint to the v1.7.1 which caught a stray actions/checkout@v2 in the codebase, which is awesome.

However, it didn't catch another instance where someone had pinned to actions/checkout@master.

Due to the possibility of pulling in a new major version or even a broken commit, my expectation is that pinning any action to master or main would default to being an actionlint failure. I'd expect this to require an explicit ignore to be accepted.

@leighmcculloch
Copy link

It'd be helpful if actionlint identified the uses of non-sha refs in third party actions, which is a security hardening best practice:

It could automatically allow actions/checkout@vN, and optionally actions from configured orgs assuming an org may want to reference their own checks with branches/tags, but not other third parties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants