Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https support for bundle download in Android #809

Open
Michael-Aca opened this issue Jul 29, 2024 · 3 comments
Open

Add https support for bundle download in Android #809

Michael-Aca opened this issue Jul 29, 2024 · 3 comments

Comments

@Michael-Aca
Copy link

Introduction

Currently is not possible to add a custom bundle URL that uses https from the React Native Dev Menu (Bridge)

Details

The url to download the bundle is hardcoded to only support http, as can be seen here:
https://github.com/facebook/react-native/blob/4cc46e3ca6845bd353d0c732a3b0f7dd6ecac4a0/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java#L390
This prevents selecting a custom https url from the Change Bundle location dialog in the Dev Menu

Discussion points

It would be great if there was the option to switch to https or if it was done automatically according to the cleartextTrafficPermitted value set in the manifest for the selected host

@unamed000
Copy link

Is there any workaround for this at the moment on your side @Michael-Aca

@Michael-Aca
Copy link
Author

Not really, but I just saw your PR and I'm excited about it

@cortinico
Copy link
Member

Currently is not possible to add a custom bundle URL that uses https from the React Native Dev Menu (Bridge)

Why would you need HTTPS to talk to the bundler?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants