Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly added quiet option in say shell is a breaking change #751

Open
xtreme-shane-lattanzio opened this issue Mar 15, 2021 · 1 comment
Open

Comments

@xtreme-shane-lattanzio
Copy link

Hey! I am from the LicenseFinder team that heavily relies on thor. I tried to track down why we are no longer getting output in newer versions of thor and found that this commit is a breaking change.

We used the quiet option to suppress basically everything except what is in say. With this, we are now getting empty string output. Was this intentional? Is there some other recommended way we should be outputting the results? We can try to change the way we do things on our end but wanted to ping here to figure out the reasoning for this change. Thanks!

@rafaelfranca
Copy link
Member

Yes. It was deliberate and not considered a breaking change, since the fact that say was not respecting quiet was a bug. We could be adding a new option to force say to print. Do you want to open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants