Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygame.mixer.Sound.copy (2577) #1328

Open
GalacticEmperor1 opened this issue Feb 12, 2023 · 5 comments · May be fixed by #3238
Open

pygame.mixer.Sound.copy (2577) #1328

GalacticEmperor1 opened this issue Feb 12, 2023 · 5 comments · May be fixed by #3238
Labels
Milestone

Comments

@GalacticEmperor1
Copy link
Collaborator

Issue №2577 opened by fortwoone at 2021-05-04 15:38:39

I noticed there were copy protocols for some important Pygame objects, such as Surfaces and Rects. I wondered if it would have some interest to add one to Sound objects too, because it would help in some situations, for example if you don't want to use imported sounds directly (also to avoid direct instance editing as we may encounter with Surfaces if we don't copy them before editing)...


Comments

# # fortwoone commented at 2021-05-13 19:00:45

And so I found a technique to copy Sound objects without using a copy method : you only need to make an array from the source Sound and then make another Sound object from the array


# # illume commented at 2021-05-22 20:12:49

Would be useful to me too.


# # fortwoone commented at 2021-05-23 10:36:01

Would be useful to me too.

Do you want me to give you my piece of code ?

@bilhox
Copy link
Contributor

bilhox commented Oct 6, 2024

hi,
I implemented it 2 weeks ago in my side, but didn't have time to fix some bugs. At least it is coming soon.

@bilhox bilhox added this to the 2.5.3 milestone Oct 17, 2024
@thomasgrgi
Copy link

@bilhox
We'd be interested in taking a look at the code and working on it with my project group if you don't have time to work on the issues, and hopefully we can find a solution.

@bilhox
Copy link
Contributor

bilhox commented Oct 23, 2024

Hi @thomasgrgi , sure !

Let me just send you the code I did when I'm back to my computer. Also don't forget to make a coauthored commit when you're ready to open a PR.

@thomasgrgi
Copy link

@bilhox
Many thanks! Of course, if we manage to fix the bugs, you'll be added as a co-author on the commit.

@bilhox
Copy link
Contributor

bilhox commented Oct 23, 2024

Here is my branch : https://github.com/bilhox/pygame-ce/tree/sound-copy

@Borishkof Borishkof linked a pull request Nov 24, 2024 that will close this issue
@yunline yunline linked a pull request Nov 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants