Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyosmeta doing odd things with the gitub username / name #227

Open
2 of 3 tasks
lwasser opened this issue Nov 19, 2024 · 1 comment
Open
2 of 3 tasks

pyosmeta doing odd things with the gitub username / name #227

lwasser opened this issue Nov 19, 2024 · 1 comment
Assignees
Labels
help wanted Extra attention is needed

Comments

@lwasser
Copy link
Member

lwasser commented Nov 19, 2024

These three issues are NOT related so i'm breaking them out.

  • DONE - 1. The user's name should always remain what is in our yml file and not get updated once it is populated. If it's fully missing then we can update it using github. It also should never be Name 😆
    here we have an example that looks like this
    Update: this was a glitch. The word "Name" was actually in the review issue - a typo / so i fixed that

see here for an example.
Screenshot 2024-11-20 at 6 46 25 PM
FIXED 🚀

  • This is an example of pyosmeta completely erasing a name. This one baffles me as Chiara has been with us for some time, and this hasn't happened before in our bot pro. This issue is also FIXED! it was because of feat: add check for EiC when parsing reviews #234, where the eic field wasn't being parsed, so it cleared out the name because the name wasn't being parsed properly.

Note =: the pr may take a bit of time to merge as it would be nice to have tests.
🚀


  • 🆘 Username should never contain the GitHub handle 🆘 this is not yet fixed!!

this
is an example of a user's name, including the GitHub username too, in our data. that is also odd and shouldn't happen.

@lwasser
Copy link
Member Author

lwasser commented Nov 21, 2024

the above issue will also close #226 which is related - but i don't know how technically related it is in the code!

@lwasser lwasser added the help wanted Extra attention is needed label Nov 21, 2024
@lwasser lwasser changed the title pyosmeta doing odd things wtih the gitub username / name pyosmeta doing odd things with the gitub username / name Nov 22, 2024
@lwasser lwasser self-assigned this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Development

No branches or pull requests

1 participant