Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-rebase? #48

Open
jywarren opened this issue Nov 5, 2018 · 5 comments
Open

Auto-rebase? #48

jywarren opened this issue Nov 5, 2018 · 5 comments

Comments

@jywarren
Copy link
Member

jywarren commented Nov 5, 2018

This app seems to be able to auto-rebase anything labeled autorebase, and i'm going to install it and try it on my own PR!

https://github.com/tibdex/autorebase

@jywarren
Copy link
Member Author

jywarren commented Nov 5, 2018

Ok, after accidentally auto-merging a PR i realized this bot will actually do a merge if it's allowed to. So I added branch protection and required a review. I think it's possible we could remove the review requirement and it still wouldn't have permissions to merge to master (i don't think it ever should).

But in #50 i don't see it auto rebasing...?

@jywarren
Copy link
Member Author

jywarren commented Nov 8, 2018

I'm worried this is stopping builds, so i'm testing turning it off: https://github.com/apps/autorebase

@icarito in case this helps!

@icarito
Copy link
Member

icarito commented Nov 9, 2018

Thanks! I'm afraid I've tried it all and for some reason gitlab is not triggering status updates on github's PRs like it was doing before. It may be because of the project rename, but even re-creating a fresh repo either with the auto-importer or manually didn't succeed:

https://gitlab.com/publiclab/pi-builder-builder/-/jobs
https://gitlab.com/publiclab/pi-builder-ci/-/jobs

And the original:

https://gitlab.com/publiclab/pi-builder/-/jobs

At this point I'm thinking of seeking gitlab support.

@jywarren
Copy link
Member Author

jywarren commented Nov 9, 2018 via email

@jywarren
Copy link
Member Author

Not sure if we got the build triggering completed, but as we make changes to the base repo, the idea of auto-rebase sounds more and more important. Thinking ahead to this a bit more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants