-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display a "pressed" state to different formatting buttons when activated #494
Comments
Wow this would be a great upgrade! I had almost forgotten how different our "bold" and "italics" work as compared to other types of formatting toolbars and buttons from around the internet. |
@keshav234156 have you thought about its implementation? From what I understand a function would check if a mode was started but hasn't ended. When would the function be called on input or a mouse click? |
This may be best implemented as part of Woofmark, (https://github.com/jywarren/woofmark/) upstream, as the buttons are part of that library. |
There may be two possibilities: Either there is already CSS driving this but it's not updated to Bootstrap 4, from woofmark, OR we may need to manually flip state by monitoring the state something like this: PublicLab.Editor/src/adapters/PublicLab.Woofmark.js Lines 357 to 361 in b1cb346
|
Implementing the feature of the darkening of all the icons when it in use. Eg. The bold icon would be darkened when in use. Similar to the feature that is present in Google Docs. We can easily work on this feature after we have introduced woofmark in the source code of PublicLab.Editor.We can get status of whether we are using a particular module from https://github.com/bevacqua/woofmark/blob/master/src/markdown/boldOrItalic.js#L15-L35 and then can implement the feature of icon highlighting for all modules so that it becomes easy for users to know which modules are currently in use.
The text was updated successfully, but these errors were encountered: