Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] thanos-sidecar volumeMounts missing #5039

Open
jhuspek opened this issue Dec 5, 2024 · 0 comments
Open

[kube-prometheus-stack] thanos-sidecar volumeMounts missing #5039

jhuspek opened this issue Dec 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jhuspek
Copy link

jhuspek commented Dec 5, 2024

Is your feature request related to a problem ?

The Prometheus CRD supports adding volumeMounts to the Thanos sidecar container, but this functionality is not currently available in the Helm chart. Additional volumes are required to include an internal CA certificate, which is necessary for establishing a secure connection to on-premise S3 storage.

Describe the solution you'd like.

Update the Helm chart to allow configuration of volumeMounts and associated volumes for the Thanos sidecar container via values.

Example Expected Configuration:

prometheus:
  prometheusSpec:
#... ...    
    thanos:
      objectStorageConfig:
        secret:
          type: S3
#... ...
      volumeMounts:
        - name: ca-certificates
          mountPath: /etc/ssl/certs/ca-certificates.crt
          subPath: ca.cer
#... ...
volumes:
  - name: ca-certificates
    configMap:
      name: cm-ca

Describe alternatives you've considered.

We can alternatively use an insecure connection to the S3 storage or the workaround mentioned in #1461 which involves overriding the Thanos sidecar container. However, this approach forces us to bypass the operator's native support, adding unnecessary complexity to operations.

Additional context.

No response

@jhuspek jhuspek added the enhancement New feature or request label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant