-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using / in HTML code for linking modules #7386
Comments
hi, can I contribute on this? @ejgutierrez74 |
If you can fix this..are you a dev ?? |
Yes, I'm @ejgutierrez74 |
You can also check my GitHub profile |
The problem sorry for my bad english is the /: as the other js scripts works with / at the beginning the sketch doesnt.... But in the div of the canvas:
Works but
Some tutorials also are outdated, as type module is missing:
The other thing should be fixed is the code for importing an element from other js files
|
Hello @ejgutierrez74,
and I am wondering if you are trying to create a sketch with its canvas in the Scripts with type="module" don't have their variables automatically added in the global scope, so module sketches wanting to use global mode need window.setup=setup instead of Regarding the paths (with or without “/”), if you are still experiencing this issue, could you create a minimal example, please? e.g. just an html page loading a very simple sketch? Paths are handled by the browser rather than p5 itself, so it would help to understand the issue. For help with debugging your sketch code specifically, it may be helpful to ask in the Discourse forum: https://discourse.processing.org/ |
Hi @Deathnote45! If you’re interested in contributing to p5.js, the contributor guidelines are here: https://p5js.org/contribute/contributor_guidelines/#new-feature-request Please note that contributors should not file a pull request (or start working on code changes) without a corresponding issue or before an issue has been approved for implementation, that is because there is no guarantee that the proposal will be accepted. Any pull requests filed before a proposal has been approved will be closed until approval is given to the issue. This feature request is still in discussion, but issues that could use help can be found under the Help Wanted label |
Sorry here is quite minimal example.... Code |
Most appropriate sub-area of p5.js?
p5.js version
1.11.1
Web browser and version
Firefox
Operating system
Linux
Steps to reproduce this
Steps:
Seems very strange: in the head of the index.html i write:
Note the / at the beginning of the path…in this case.working fine…
But in the div of the canvas:
Works but
With the / doesn’t work, also i have to write type=“module” in other tutorials don’t appear this type only:
<script src="sketch.js"></script>
Also i still think that window.setup = setup and window.draw=draw at the end of sketch.js should no be there…if you export and import a js file, just it, don’t know why window is doing here…
Would be nice if any dev could fix this-
Code
https://drive.google.com/file/d/1J_BBQANpS7U7OEIRlrfx-UCeveXPhDUG/view
Also could be an idea or enhancement for p5.js 2.0
Snippet:
// Paste your code here :)
The text was updated successfully, but these errors were encountered: