fix: escape key closes hints without blocking typing #3281
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
There was a problem hiding this comment.
Thanks for your work on this!
While this solution does seem to work, I'm wondering if it might be better to try to work with the keymapping instead, as it's already been established within this file? It would also be great if you could remove the comments next to each line within your code!
|
Thanks so much again for your work on this! While this is functional, I don't think this is a complete solution yet and might need some further work to get there. Since it's been a while since this PR was last active, I'm going to close this for now. I'm sorry that we couldn't get this in, but please feel free to reopen this PR with any updates or check out our other issues! |
Fixes #3252
Changes: Ensures that pressing the escape key closes the hint box without preventing the user from typing in the editor. The editor should remain responsive after closing the hint.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #3252