-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Edit Ability for Non-owned sketches #870
Comments
i agree that it is not clear when you are looking at a sketch that is yours vs one that is not. i'm open to discussion and ideas about how to make this clearer! |
There can be 2 courses of action according to me, 1. The option should be blurred out and on hovering on the disabled button, there should be a Tooltip (in language of Material Design) displaying that the user should clone the sketch first. |
Since there are no tool tips anywhere in the menu as it exists, it seems like a better solution would be to use an alert / modal for notification. It feels more immediate and would require very limited scope to implement. as a third option, we could simply disable menu items based on the relationship of the sketch to the owner. eg. if you don't own the sketch, don't show the add file/folder. yet another option (I present this with healthy skepticism) is to add a duplicate button to the front of the UI if you are looking at a sketch you dont own. |
@bmoren According to me adding Duplicate Sketch button in the front of UI would not convey the fact that one needs to duplicate it in order to add files or folders(and would give a more general |
I'd love to see this implemented (I might have time to work on it during next semester). During this semester, I've again had students get stuck here frustrated they couldn't upload files only to realize that they'd not duplicated the sketch yet. So I still feel like its something that would improve the overall experience! |
Hey, @catarak!! |
Hello! I am a new comer to open source and trying to do my first pull request. So I need a little help. Is there a way to know current users id also including the case when user is not logged in? |
Oh! actually I checked your github folk to but didn't found anything but now in some days I will get it. By the best of luck for your pull request. Hope community founds it useful. |
Hey @catarak, Screen.Recording.2021-02-25.at.3.32.50.PM.movI thought using the toast functionality which we use in many other cases is the way to go. |
Hey @catarak, please look into this |
First time contributing to open source. Is this issue unresolved? if it is I would like to work on it |
Nature of issue?
Existing feature enhancement
Web browser and version: FF 65.0.1 (64-bit)
Operating System: OSX 10.13.4
Steps to reproduce this bug: Open a sketch that is not owned by your account and attempt to add a file in the sketch menu
Feature enhancement details:
When looking at a sketch that is not your own (under you logged in account) you cannot add a file / folder. This is expected behavior, but I feel that there should be some feedback there to let you know that you're attempting to work on a sketch that is not your own. Especially because you can edit the code and have it run even if it's not technically 'your' sketch yet.
Either blocking out those menu items or giving a dialogue that they need to duplicate the sketch first might be options?
The text was updated successfully, but these errors were encountered: