-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert legacy React class components to function components #2358
Comments
Convert EmailVerificationView to function component #2401 |
i want to work to work to convert the collectionListRowbase component and make a PR. can i do it? |
Hi @lindapaiste , It seems like you are working on this issue quite long time, |
Thank you everyone for all of your work on this! It looks like all components have been covered in pending PRs. We do not need any more new PRs for this issue. |
@lindapaiste could you please take my PR into consideration and review it |
Can I work on DashboardView if anyone didn't? |
Ref #2447 . |
Normally I would not close an issue until all of the PRs are merged. But I'm going to close this so y'all will stop submitting unnecessary PRs. |
@lindapaiste what about my PR. will it be considered or closed? as a beginner i didn't understand your point.. please tell me |
I didn't understand either |
Hi @lindapaiste , I'd like to contribute to this issue, if this issue is still open. |
Increasing Access
It keeps the codebase up to date and makes it easier for new contributors.
Feature enhancement details
React.Component
is considered a legacy API and is not recommended. We should convert all class components to function components which use React hooks.This is mainly a "Progress Report" for myself because with so many unmerged PRs sometimes I forget what I've already worked on!
Here are the class components which remain the codebase, and the PRs to convert them:
App
to a function component. #2308Overlay
to a function component, shares logic withModal
#2309AddToCollectionList
component #2353AddToCollectionSketchList
to a function component #2364CopyableInput
to a function component #2360Toolbar
to a function component #2352Preferences
into a function component #2335APIKeyForm
to a function component and connect to Redux #2307Collection
to a function component #2366CollectionView
#2302The text was updated successfully, but these errors were encountered: