Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert legacy React class components to function components #2358

Closed
14 of 24 tasks
lindapaiste opened this issue Aug 7, 2023 · 11 comments
Closed
14 of 24 tasks

Convert legacy React class components to function components #2358

lindapaiste opened this issue Aug 7, 2023 · 11 comments
Assignees

Comments

@lindapaiste
Copy link
Collaborator

lindapaiste commented Aug 7, 2023

Increasing Access

It keeps the codebase up to date and makes it easier for new contributors.

Feature enhancement details

React.Component is considered a legacy API and is not recommended. We should convert all class components to function components which use React hooks.


This is mainly a "Progress Report" for myself because with so many unmerged PRs sometimes I forget what I've already worked on!

Here are the class components which remain the codebase, and the PRs to convert them:

@vijayabhaskar-ev
Copy link

Convert EmailVerificationView to function component #2401

@KSSaiTeja
Copy link

i want to work to work to convert the collectionListRowbase component and make a PR. can i do it?

@shauryag2002
Copy link

Hi @lindapaiste , It seems like you are working on this issue quite long time,
if not able to do it !
Can @lindapaiste assign it to me?

@lindapaiste
Copy link
Collaborator Author

Thank you everyone for all of your work on this! It looks like all components have been covered in pending PRs.

We do not need any more new PRs for this issue.

@KSSaiTeja
Copy link

@lindapaiste could you please take my PR into consideration and review it

@up1512001
Copy link

Can I work on DashboardView if anyone didn't?

@thakkarnetram
Copy link

Ref #2447 .
I have updated the Assets List to a functional component

@lindapaiste
Copy link
Collaborator Author

Normally I would not close an issue until all of the PRs are merged. But I'm going to close this so y'all will stop submitting unnecessary PRs.

@KSSaiTeja
Copy link

@lindapaiste what about my PR. will it be considered or closed? as a beginner i didn't understand your point.. please tell me

@thakkarnetram
Copy link

@lindapaiste what about my PR. will it be considered or closed? as a beginner i didn't understand your point.. please tell me

I didn't understand either

@umangutkarsh
Copy link
Contributor

Hi @lindapaiste , I'd like to contribute to this issue, if this issue is still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment